-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address oai.samvera validation issues #514
Conversation
866b44b
to
e337335
Compare
I'm confused why there's so much happening in this mapper but there was so little happening in the legacy mapper: https://github.com/calisphere-legacy-harvester/dpla-ingestion/blob/cfe3dcb06008c0c6cb9d8207fe28bfaa1a855e4f/lib/mappers/ucsc_oai_mapper.py#L6 Are there things that should be happening in the base OAI mapper class that aren't??? |
40e87f3
to
3ef092d
Compare
@christinklez @aturner @amywieliczka @barbarahui I'm attaching a screenshot and a full CSV of the validation report from collection 154 after fixing a few things. There are some questions:
|
@lthurston In looking at what we've previously harvested from the old fetcher/mapper vs. Rikolti results, it looks like the first 3 items can be attributed to data drift. UCLA has been migrating content across new systems, so the change to the item landing page/edm:isShownAt URL makes sense. We are AOK with the multiple dates, and also the reordered subjects. |
3ef092d
to
eefdbaa
Compare
7aaff59
to
c9afb77
Compare
c9afb77
to
4e79dc6
Compare
7f7ba07
to
cea7453
Compare
Marking this as ready for review and merging as these updates make sense for a re-inventory of OAI mappers. |
No description provided.