Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize memory usage for FieldDeclarationNode #233

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

nimakarimipour
Copy link
Member

@nimakarimipour nimakarimipour commented Jun 10, 2024

This PR improves the memory usage of FieldDeclarationNode instances, significantly reducing the memory allocation during the execution of Annotator. The main change involves replacing the reference to DeclarationNode with boolean variables, which store the necessary information previously retrieved through the DeclarationNode reference.

@nimakarimipour nimakarimipour self-assigned this Jun 10, 2024
@nimakarimipour nimakarimipour added the enhancement New feature or request label Jun 10, 2024
@nimakarimipour nimakarimipour changed the title optimize memory usage for FieldDeclarationNode Optimize memory usage for FieldDeclarationNode Jun 10, 2024
@nimakarimipour nimakarimipour requested a review from msridhar June 10, 2024 21:29
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@nimakarimipour nimakarimipour merged commit cb09962 into master Jun 10, 2024
7 checks passed
@nimakarimipour nimakarimipour deleted the nimak/mem-opt branch June 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants