Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up fixIsSource flag from fix class #243

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

nimakarimipour
Copy link
Member

@nimakarimipour nimakarimipour commented Oct 3, 2024

This PR removes the unused flag fixIsSource which indicates if the fix is suggested from an error in the source code of target or downstream dependency. This flag is not used in the latest logic anymore and is redundant. This PR removes this flag from the fix class declaration.

@nimakarimipour nimakarimipour self-assigned this Oct 3, 2024
@nimakarimipour nimakarimipour added the refactoring/simplification Refactoring Simplification label Oct 3, 2024
@nimakarimipour nimakarimipour merged commit 7cfb5c6 into master Oct 3, 2024
7 checks passed
@nimakarimipour nimakarimipour deleted the nimak/flag-cleanup-on-fix branch October 3, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring/simplification Refactoring Simplification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant