Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createErrorToSubclass method to subclass #246

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Move createErrorToSubclass method to subclass #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
093f590
Moves createError to subclass
nimakarimipour Oct 3, 2024
2028025
add javadoc:
nimakarimipour Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions annotator-core/src/main/java/edu/ucr/cs/riple/core/checkers/Checker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
import edu.ucr.cs.riple.core.module.ModuleConfiguration;
import edu.ucr.cs.riple.core.module.ModuleInfo;
import edu.ucr.cs.riple.core.registries.index.Error;
import edu.ucr.cs.riple.core.registries.index.Fix;
import edu.ucr.cs.riple.core.registries.region.Region;
import java.util.Set;

/**
Expand Down Expand Up @@ -63,25 +61,6 @@ public interface Checker<T extends Error> {
*/
void preprocess(AnnotationInjector injector);

/**
* Creates an {@link Error} instance from the given parameters.
*
* @param errorType Error type.
* @param errorMessage Error message.
* @param region Region where the error is reported,
* @param offset offset of program point in original version where error is reported.
* @param resolvingFixes Set of fixes that resolve the error.
* @param module Module where the error is reported.
* @return The corresponding error.
*/
T createError(
String errorType,
String errorMessage,
Region region,
int offset,
ImmutableSet<Fix> resolvingFixes,
ModuleInfo module);

/**
* Verifies that the checker representation in Annotator is compatible with the actual running
* checker on the target module.
Expand Down
16 changes: 14 additions & 2 deletions annotator-core/src/main/java/edu/ucr/cs/riple/core/checkers/nullaway/NullAway.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,20 @@ public void preprocess(AnnotationInjector injector) {
injector.injectAnnotations(initializers);
}

@Override
public NullAwayError createError(
/**
* Creates a {@link NullAwayError} instance using the provided arguments. It also removes
* annotation change requests that are on an element with explict nonnull annotation.
*
* @param errorType Error Type from NullAway.
* @param errorMessage Error Message from NullAway.
* @param region Region where the error is reported.
* @param offset Offset of program point in the source file where the error is reported.
* @param resolvingFixes Resolving fixes that can fix the error if all applied to source code.
* @param module Module where this error is reported.
* @return Creates and returns the corresponding {@link NullAwayError} instance using the provided
* information.
*/
private NullAwayError createError(
String errorType,
String errorMessage,
Region region,
Expand Down
Loading