Fixing inconsistent room and tab selection upon back navigation within the all patients tab, particularly in room 4. #515

[alfino77]

Fix Description
This pull request addresses the inconsistency in room and tab selection when navigating back within the "All Patients" tab, specifically in Room 4. The issue was caused by the browser not retaining the previously selected tab index.

Solution
To resolve this, the implementation utilizes the browser's local storage to store the index of the last selected tab. Upon initializing the component, the stored tab index is retrieved, allowing the browser to automatically select the correct tab. This ensures consistent user experience during back navigation.

Related Issue
Resolves #515

Link
https://github.com/alfino77/iCareConnect/tree/group43

Participants
MAGANGA, Emmanuel Msoma 2022-04-05599
KAZIMOTO, Meshack Daniel 2022-04-03968
SEIF, Sabra Haroub 2022-04-12051
YUSUFU, Kauthar Abdul 2022-04-13449
ABDULLAH, Ahmed Khalfan 2022-04-00089

[Moricembiaji]

Hello, everyone! For those who have completed their assignment tasks, please follow these steps to submit your work: 1. *Create a Feature Branch* - Name the branch based on the task you're working on, e.g., feature/labnotification. 2. *Push Your Work* - Push all your changes to the newly created feature branch. 3. *Create a Pull Request* - Create a pull request directed to the account named iamgaspardev for review of your work. *Note:* - Do not push changes to your personal GitHub account. - Push from the repository you pulled from and ensure the changes are in the feature branch you created. Thanks and Regards, Ramadhani Mbiaji Health Information System Analyst UDSM DHIS2 LAB <https://dhis2.udsm.ac.tz/#/home> College of Information and Communication Technology (CoICT) Department of Computer Science and Engineering University of Dar-es-salaam Mobile Number: *+255 693 012 480* Useful Links: GitHub <https://github.com/Ramadhani202208>, LinkedIn <https://www.linkedin.com/in/ramadhani-mbiaji-2881b0ab/> Website: https://dhis2.udsm.ac.tz

…

On Fri, 17 Jan 2025 at 15:30, alfino77 ***@***.***> wrote: *Fix Description* This pull request addresses the inconsistency in room and tab selection when navigating back within the "All Patients" tab, specifically in Room 4. The issue was caused by the browser not retaining the previously selected tab index. *Solution* To resolve this, the implementation utilizes the browser's local storage to store the index of the last selected tab. Upon initializing the component, the stored tab index is retrieved, allowing the browser to automatically select the correct tab. This ensures consistent user experience during back navigation. *Related Issue* Resolves #515 <#515> *Link* https://github.com/alfino77/iCareConnect/tree/group43 *Participants* MAGANGA, Emmanuel Msoma 2022-04-05599 KAZIMOTO, Meshack Daniel 2022-04-03968 SEIF, Sabra Haroub 2022-04-12051 YUSUFU, Kauthar Abdul 2022-04-13449 ABDULLAH, Ahmed Khalfan 2022-04-00089 ------------------------------ You can view, comment on, or merge this pull request online at: #539 Commit Summary - 2065e08 <2065e08> Store active tab index in local storage, AHMED KHALFAN ABDULLAH 2022-04-00089 - dfc62c9 <dfc62c9> Declared a variable for saved selected tab, emmanuel msoma2022-04-05599 - b8da336 <b8da336> Getting active tab index from local storage, KAZIMOTO, Meshack Daniel, 2022-04-03968 - cd8c0cc <cd8c0cc> Setting state of selected tab to tab index, KAUTHAR ABDUL YUSUFU, 2022-04-13449 - f4a47b3 <f4a47b3> Correct logical operator in all patients tab, SABRA HAROUB SEIF, 2022-04-12051 File Changes (2 files <https://github.com/udsm-dhis2-lab/iCareConnect/pull/539/files>) - *M* ui/src/app/modules/clinic/pages/clinic-patient-list/clinic-patient-list.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/539/files#diff-772dc02396324390660fcc1d13b31f39dccfba3f6b5b89c30acf26f18fbe2907> (2) - *M* ui/src/app/modules/clinic/pages/clinic-patient-list/clinic-patient-list.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/539/files#diff-742a3eea57e15219c5012e7ef77db22630beff1e7dae284e21e4fdcfb1d4fc4d> (8) Patch Links: - https://github.com/udsm-dhis2-lab/iCareConnect/pull/539.patch - https://github.com/udsm-dhis2-lab/iCareConnect/pull/539.diff — Reply to this email directly, view it on GitHub <#539>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2TLCLC4NYBARK6BCGFWFH32LDZUVAVCNFSM6AAAAABVL2EFJ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TKMZXGA4TSMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>