Ros2 Migration Maanas Kotha #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrxyz
requested changes
Apr 13, 2024
| was not received. | ||
| PnuematicActuatorDriverChecksumError: The checksum expected and the checksum | ||
| received were not the same def get_port(self, port: int) -> int: | ||
| """ |
| from mil_misc_tools.serial_tools import SimulatedSerial | ||
|
|
||
| from .constants import Constants | ||
|
|
||
|
|
||
| class SimulatedPnuematicActuatorBoard(SimulatedSerial): | ||
| class SimulatedPnuematicActuatorBoard(SimulatedSerial, Node): |
| @@ -65,7 +67,7 @@ def __init__(self): | |||
| super().__init__(message) | |||
|
|
|||
|
|
|||
| class PnuematicActuatorDriver: | |||
| class PnuematicActuatorDriver(Node): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated mil_pneumatic_actuator for ROS2
Related Issues
Addresses Issue #1124
Testing
This package utilized packages that are Ros 1 Compatible and needed to be replaced with their Ros 2 equivalent. I am not sure if the packages will solve this completely but the structure should be right. I will need help to test.