feat: support using predefined controller extensions#120
Merged
akudev merged 1 commit intoui5-community:mainfrom Nov 30, 2023
Merged
feat: support using predefined controller extensions#120akudev merged 1 commit intoui5-community:mainfrom
akudev merged 1 commit intoui5-community:mainfrom
Conversation
When using a controller extension in your own controller as a kind of mix-in, UI5 currently expects in the "extend" config object the extension class to be assigned to a property. In TypeScript, however, the TS compiler must see the property being typed with an *instance* of the extension class, so subsequent calls to the extension can be written like they should (this.routing.doSomething()). This change introduces the "@transformControllerExtension" comment and decorator which triggers a special kind of transformation for annotated class properties. The controller extension type assigned to the subsequent class property is then assigned as class in the extend object in JavaScript. And this assignment is not moved into the constructor like it normally would be. Fixes UI5/typescript#420
Collaborator
Author
|
The high-level approach here is:
|
petermuessig
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a controller extension in your own controller as a kind of mix-in, UI5 currently expects in the "extend" config object the extension class to be assigned to a property.
In TypeScript, however, the TS compiler must see the property being typed with an instance of the extension class, so subsequent calls to the extension can be written like they should
(this.routing.doSomething()).
This change introduces the "@transformControllerExtension" comment and decorator which triggers a special kind of transformation for annotated class properties. The controller extension type assigned to the subsequent class property is then assigned as class in the extend object in JavaScript. And this assignment is not moved into the constructor like it normally would be.
Fixes UI5/typescript#420