optimize select - use object for storing options

ujjwalguptaofficial · Jul 27, 2020 · 6d83202 · 6d83202
1 parent bb7b495
commit 6d83202
Showing 1 changed file with 9 additions and 17 deletions.
diff --git a/src/grammar/select.pegjs b/src/grammar/select.pegjs
@@ -1,25 +1,21 @@
 
 
 selectQuery = SELECT _+ ("*"_+)? as: asQuery? aggr:aggregateQry? FROM _ table:tableName _* join:joinQry* _* where:whereQry? _* 
-option:(skip/limit/distinct/orderBy/groupBy)* {
-  var skip=null;
-  var limit=null;
-  var distinct = false;
-  var order = null;
-  var groupBy = null;
-  option.forEach(val=>{
+options:(skip/limit/distinct/orderBy/groupBy)* {
+  const option = {};
+  options.forEach(val=>{
   	var key = Object.keys(val)[0];
     switch(key){
     	case 'skip':
-         	skip= val[key]; break;
+         	option.skip= val[key]; break;
         case 'limit':
-            limit= val[key]; break;
+            option.limit= val[key]; break;
         case 'distinct':
-        	distinct = val[key]; break;
+        	option.distinct = val[key]; break;
         case 'order':
-        	order = val[key]; break;
+        	option.order = val[key]; break;
          case 'groupBy':
-        	groupBy = val[key]; break;
+        	option.groupBy = val[key]; break;
     }
   });
   let modifiedWhere ;
@@ -66,11 +62,7 @@ option:(skip/limit/distinct/orderBy/groupBy)* {
      data:{
         from:table,
         where:modifiedWhere,
-        skip:skip,
-        limit:limit,
-        distinct : distinct,
-        order:order,
-        groupBy:groupBy,
+        ...option,
         aggregate : aggr,
         join:join.length===0?null:join
      }