Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIME-119] 투표 통합 테스트 추가 #60

Merged
merged 18 commits into from
Mar 10, 2024
Merged

[LIME-119] 투표 통합 테스트 추가 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
509c2d1
chore: 테스트를 위한 h2 의존성 추가
Yiseull Feb 27, 2024
64caf29
test: 투표 생성 통합 테스트 추가
Yiseull Feb 27, 2024
d3933ad
test: 투표 참여 통합 테스트 추가
Yiseull Feb 28, 2024
9ee1db3
test: 투표 참여 통합 테스트 코드 중복 제거
Yiseull Feb 28, 2024
72f5980
test: 테스트 설명을 사용자 관점의 기능 명세로 변경
Yiseull Feb 28, 2024
b25972d
test: 투표 생성 테스트에 verify 추가
Yiseull Feb 28, 2024
ba3408a
test: 투표 참여 취소 테스트 추가
Yiseull Feb 29, 2024
b65010a
test: 투표 삭제 테스트 추가
Yiseull Mar 1, 2024
b42162a
test: 투표 서비스 테스트 리팩토링
Yiseull Mar 1, 2024
59ae6cf
test: 투표 상세 조회 테스트 추가
Yiseull Mar 1, 2024
4a953fe
test: 투표 상세 조회 테스트 추가
Yiseull Mar 2, 2024
321a036
comment: 주석 위치 변경
Yiseull Mar 2, 2024
5d799aa
test: 투표 목록 조회 테스트 추가
Yiseull Mar 4, 2024
a2a927c
chore: H2 의존성 제거
Yiseull Mar 4, 2024
8838b43
fix: 커서 파라미터가 Swagger에서 필수 입력값인 문제와 Json 형태로 입력받는 문제 해결
Yiseull Mar 4, 2024
eb9123e
fix: 총 검색된 투표 수와 실제 검색되는 투표 수가 다른 버그 해결
Yiseull Mar 4, 2024
3c85c2d
feat: 투표 제목에 대해서도 검색되는 요구사항 추가
Yiseull Mar 4, 2024
99f06cf
test: 투표 키워드 검색 테스트 추가
Yiseull Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lime-api/src/main/java/com/programmers/lime/domains/vote/api/VoteController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public ResponseEntity<VoteGetByCursorResponse> getVotesByCursor(
@RequestParam final String hobby,
@RequestParam(required = false, name = "status") final String statusCondition,
@RequestParam(required = false, name = "sort") final String sortCondition,
@ModelAttribute @Valid final CursorRequest request
@ModelAttribute final CursorRequest request
) {
final CursorSummary<VoteSummary> cursorSummary = voteService.getVotesByCursor(
Hobby.from(hobby),
Expand All @@ -112,7 +112,7 @@ public ResponseEntity<VoteGetByCursorResponse> getVotesByCursor(
@GetMapping("/search")
public ResponseEntity<VoteGetByKeywordResponse> getVotesByKeyword(
@RequestParam final String keyword,
@ModelAttribute @Valid final CursorRequest request
@ModelAttribute final CursorRequest request
) {
final VoteGetByKeywordServiceResponse serviceResponse = voteService.getVotesByKeyword(keyword,
request.toParameters());
Expand Down
9 changes: 6 additions & 3 deletions lime-api/src/main/java/com/programmers/lime/global/cursor/CursorRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
package com.programmers.lime.global.cursor;

import org.springdoc.core.annotations.ParameterObject;

import com.programmers.lime.common.cursor.CursorPageParameters;

import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.Parameter;

@ParameterObject
public record CursorRequest(
@Schema(description = "커서아이디, 첫 조회는 커서아이디 없는 요청입니다.", example = "2023110124000001")
@Parameter(description = "커서아이디, 첫 조회는 커서아이디 없는 요청입니다.", example = "2023110124000001")
String cursorId,

@Schema(description = "페이징 사이즈입니다", example = "10")
@Parameter(description = "페이징 사이즈입니다", example = "10")
Integer size
) {
public CursorPageParameters toParameters() {
Expand Down
Loading
Loading