Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/legacy api header #24

Closed
wants to merge 26 commits into from
Closed

Feature/legacy api header #24

wants to merge 26 commits into from

Conversation

stephen-dixon
Copy link
Contributor

@stephen-dixon stephen-dixon commented Jan 24, 2024 •
edited
Loading

  • Legacy wrapper functions created
  • All api functions renamed to udaBlah
  • All references to previous API functions updated
  • client_flags argument removed from all API function signatures
  • builds successfully on macos and github CI
  • turned off compilation of java wrapper

todo

  • move udaCloseAllConnections() to from client/connection.cpp to c_api directory?

@stephen-dixon
correcting uda error log calls from addIdamError to udaAddError in ap…
1d0e2a5 
…i headers themselves
@stephen-dixon
removing references to client flags in client wrappers
ea32085
@stephen-dixon
renaming struct api functions to include uda keyword e.g. udaAddMalloc()
3e187dd
@stephen-dixon
renaming IDAM_PLUGIN_INTERFACE to UDA_PLUGIN_ITERFACE
cf2eff0
@stephen-dixon
correcting bad replace from reudaSetProperty to udaResetProperty
e90c93b
@stephen-dixon
renaming some missed struct functions from e.g. findNTreeFoo to udaFi…
9112b1a 
…ndNTreeFoo
@stephen-dixon
fixing some compilation issues
65eb45e
@stephen-dixon
removing repeated API definition between accAPI and accessors
d380fda
@stephen-dixon
fixing compile errors
4089dc7
@stephen-dixon
successfully compiles on macos
2f7d61f
@stephen-dixon
removing java wrapper from cmake
a3f5a5c
@stephen-dixon
fixing pyuda build and renaming missed init struct api functions
4af76f7
@stephen-dixon
running clang format
0556b96
@stephen-dixon stephen-dixon marked this pull request as ready for review January 26, 2024 10:19
@jholloc jholloc closed this Mar 27, 2024
@jholloc jholloc deleted the feature/legacy_api_header branch March 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-parker1 adam-parker1 adam-parker1 left review comments

@jholloc jholloc Awaiting requested review from jholloc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-dixon @adam-parker1 @jholloc