Avoid long worrying log line at info level #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is an info level log line when checking if a datastream exists, but it includes the entire error even though it is caught and expected.
This results in long worrying looking log messages which are in fact not a problem (once you notice that they are info level) e.g. like this:
```
[info]: #0 Specified data stream does not exist. Will be created: <[404] {"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no such index [my.datastream.name]","resource.type":"index_or_alias","resource.id":"my.datastream.name","index_uuid":"_na_","index":"my.datastream.name"}],"type":"index_not_found_exception","reason":"no such index [my.datastream.name]","resource.type":"index_or_alias","resource.id":"my.datastream.name","index_uuid":"_na_","index":"my.datastream.name"},"status":404}>
```
so simplify it to instead just log the name of the datastream.
We know what the error is going to be given it is being caught explicitly.
cosmo0920
reviewed
Jan 15, 2024
cosmo0920
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an info level log line when checking if a datastream exists, but it includes the entire error even though it is caught and expected.
This results in long worrying looking log messages which are in fact not a problem (once you notice that they are info level) e.g. like this:
We know what the error is going to be given it is being caught explicitly, so instead simplify and just log the name of the datastream which looks much nicer like this instead:
I don't think any of the below checklist are relevant but please let me know if you think they are.
Thanks!
(check all that apply)
versionin gemspec are untouchedelasticsearch_dynamic(not required but recommended)