Receive const char * from PyUnicode_AsUTF8
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.7, `PyUnicode_AsUTF8` was changed to return a `const char *` instead of a `char *`. This broke VIGRA as we were accepting a `char *` in this case instead. Fortunately we do not need it to be mutable for our use case. So just type the variable storing the result from `PyUnicode_AsUTF8` as a `const char *`. Should still work on older Python 3 versions that return `char *` as well. ref: https://bugs.python.org/issue28769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.7,
PyUnicode_AsUTF8was changed to return aconst char *instead of achar *. This broke VIGRA as we were accepting achar *in this case instead. Fortunately we do not need it to be mutable for our use case. So just type the variable storing the result fromPyUnicode_AsUTF8as aconst char *. Should still work on older Python 3 versions that returnchar *as well.xref: #450
ref: https://bugs.python.org/issue28769