Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp from 3.8.6 to 3.9.0 (amended) #1106

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

paulpepper-trade
Copy link
Collaborator

Bumps aiohttp from 3.8.6 to 3.9.0.


updated-dependencies:

  • dependency-name: aiohttp dependency-type: direct:production ...

TP2000-1137 Dependabot alert: aiohttp's ClientSession is vulnerable to CRLF injection

Why

Dependabot-generated PR was failing unit tests due to incorrect mocking behaviour in aioresponses after bumping to aiohttp version 3.9.0 (possibly having introduced a breaking change to the aiohttp.ClientResponse or aiohttp.ClientSession APIs).

Also bump aiohttp to latest version, 3.9.1.

What

Additionally bump the version of aioresponse, which appears to fix the response or session management issue / incompatibility.

Checklist

  • Requires migrations? No
  • Requires dependency updates? Yes

dependabot bot and others added 3 commits November 28, 2023 01:00
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.6 to 3.9.0.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.8.6...v3.9.0)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c5fe135) 92.72% compared to head (a8a97c8) 92.73%.
Report is 3 commits behind head on master.

Files Patch % Lines
common/forms.py 83.33% 0 Missing and 1 partial ⚠️
workbaskets/tests/test_models.py 83.33% 1 Missing ⚠️
workbaskets/views/ui.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   92.72%   92.73%           
=======================================
  Files         460      460           
  Lines       35157    35211   +54     
  Branches     2694     2690    -4     
=======================================
+ Hits        32600    32652   +52     
- Misses       2028     2029    +1     
- Partials      529      530    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulpepper-trade paulpepper-trade merged commit 4e06715 into master Dec 5, 2023
3 checks passed
@paulpepper-trade paulpepper-trade deleted the dependabot/pip/aiohttp-3.9.0--fixed branch December 5, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants