TP2000 1650 commodities snapshot behaviour #1379
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2025 11:45
Luisella21
changed the title
dalecannon
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Might this file be better served as an addition to .gitignore to allow for local, personalised .envrc configurations?
Comment on lines
+97
to
+98
| def test_CommodityCollectionLoader(seed_database_with_indented_goods): | ||
| # Test that effective_only does not crash the code |
There was a problem hiding this comment.
Perhaps the comment could form part of the test name to reflect what in particular is being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1650 commodities snapshot behaviour with effective_only=True
Using CommodityCollectionLoader.load(effective_only=True) gives an error, because a filter is applied to a non existing field.
Added a small test showing the issue, and changed the code to fix it.