menuconfig: Avoid crashing when leaving a menu not shown in parent #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a catch to an exception that might occur when leaving a menu which is not shown by the parent menu. For an example of this refer to issue ulfalizer#93.
|
Rather unfortunately, it appears the original author of Kconfiglib disappeared. The Zephyr project has been granted ownership of the PyPI package via PEP-541 request, and I'm going to do a release based on a new repository in the ➡️ Action required: @leandrolanzieri Are you able to re-open your pull request on the new repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a catch to an exception that might occur when leaving a menu which is not shown by the parent menu. For an example of this refer to issue #93.
For the snippet given in #93 this ends up showing the top menu. I'm not sure if this is the expected behaviour (after all, the second definition of the choice is defined in the top menu), or 'Sub' menu should be shown. At least this seems to avoid the crash.