Backtranslation of contracts with handling of "modifies" clause #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During backtranslation of contracts from Boogie to C we must encode the Boogie procedure's "modifies" clause into the C function's contract. To do so properly, we need a specialized backtranslation of contracts.
- do not generate equalities for type declarations - do not crash if variable cannot be backtranslated but output a backtranslation warning
maul-esel
requested review from
Heizmann,
bahnwaerter,
danieldietsch,
schuessf and
ebbima
schuessf
reviewed
Oct 16, 2024
...e/uni_freiburg/informatik/ultimate/plugins/generator/cacsl2boogietranslator/Boogie2ACSL.java
Show resolved
Hide resolved
...e/uni_freiburg/informatik/ultimate/plugins/generator/cacsl2boogietranslator/Boogie2ACSL.java
Show resolved
Hide resolved
...e/uni_freiburg/informatik/ultimate/plugins/generator/cacsl2boogietranslator/Boogie2ACSL.java
Show resolved
Hide resolved
...e/uni_freiburg/informatik/ultimate/plugins/generator/cacsl2boogietranslator/Boogie2ACSL.java
Outdated
Show resolved
Hide resolved
schuessf
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the backtranslation of procedure contracts.
modifiesclauses to encode frame conditions) to C/ACSL (where our contracts currently do not havemodifiesor other features for frame conditions), we add conjuncts of the formx == \old(x)for variables that are not modifiable by the procedure.ITranslatorinterface.