Support __atomic_compare_exchange
#689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maul-esel
requested review from
bahnwaerter,
danieldietsch,
schuessf and
ebbima
schuessf
reviewed
Oct 22, 2024
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Show resolved
Hide resolved
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
schuessf
reviewed
Oct 22, 2024
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
schuessf
reviewed
Oct 22, 2024
.../ultimate/cdt/translation/implementation/base/standardfunctions/StandardFunctionHandler.java
Outdated
Show resolved
Hide resolved
While likely not a soundness problem, this is problematic due to the LBE performed by CfgBuilder which fuses the overapproximation assert with other statements, such that the entire block is marked as over- approximation. Thus we report UNKNOWN unnecessarily.
…icCompareExchangeN
…ionFactory for built-in simplication
maul-esel
force-pushed
the
wip/dk/atomic-cas
branch
from
505c283 to
1a5de2f
Compare
Follow description in C standard rather than unclear cppref / GNU descriptions (the C standard is still pretty vague though). Introduce some auxiliary methods to make the code easier to read. Optimize code when "weak" argument is a literal and adapt a program to test this.
schuessf
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the builtin atomic functions
__atomic_compare_exchange_nand__atomic_compare_exchange.