Support quantifiers in ACSL #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maul-esel
reviewed
Jan 7, 2025
.../de/uni_freiburg/informatik/ultimate/cdt/translation/implementation/base/MainDispatcher.java
Show resolved
Hide resolved
...ltimate/cdt/translation/implementation/base/expressiontranslation/ExpressionTranslation.java
Outdated
Show resolved
Hide resolved
...src/de/uni_freiburg/informatik/ultimate/cdt/translation/implementation/base/ACSLHandler.java
Outdated
Show resolved
Hide resolved
...src/de/uni_freiburg/informatik/ultimate/cdt/translation/implementation/base/ACSLHandler.java
Outdated
Show resolved
Hide resolved
|
Regarding the test cases: I wanted to wait for #703 to write some tests with quantifiers over arrays, but I will just add some simple tests to demonstrate the basic functionality, |
danieldietsch
approved these changes
Jan 7, 2025
...src/de/uni_freiburg/informatik/ultimate/cdt/translation/implementation/base/ACSLHandler.java
Outdated
Show resolved
Hide resolved
schuessf
force-pushed
the
wip/fs/acsl-quantifiers
branch
2 times, most recently
from
ca48b46 to
d288eb8
Compare
maul-esel
reviewed
Jan 10, 2025
...k/ultimate/cdt/translation/implementation/base/expressiontranslation/IntegerTranslation.java
Show resolved
Hide resolved
...ormatik/ultimate/plugins/generator/codecheck/preferences/CodeCheckPreferenceInitializer.java
Outdated
Show resolved
Hide resolved
* Introduce ScopedHashMap for quantified variables and use it for the handling of IdentifierExpressions * Use type constraints in Boogie-quantifiers (with implication for \forall and "and" for \exists)
Otherwise the tests with quantifiers fail
schuessf
force-pushed
the
wip/fs/acsl-quantifiers
branch
from
7253c6b to
e4645c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for quantifiers in ACSL.
NotDefinedExpression. There was also a AST object for aQuantifierExpressionthat I just adapted to our needs.ACSLHandler. The crucial steps in this translation are that we have to handle the quantified variables in the expression inside the quantifier properly (track the variables in aScopedHashMapand first lookup when handling anIdentifierExpression) and that we add type constraints over the quantified variables (ACSL may use bounded types that are translated to an unbounded type in Boogie).Note that we can only handle quantified expressions, where the inner expressions is side-effect free (which also does not allow any auxiliary statements). Therefore, quantified expressions that contain dereferences are currently not supported, but this should be fixed in #703.