Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FakePointerExpression out of ACSL AST & refactor pointer backtranslation #708

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

maul-esel
Copy link
Contributor

Following up on this discussion on #707:

  • Add a common supertype BacktranslatedACSLValue for BacktranslatedExpression and a new FakePointer record (which replaces FakePointerExpression). The new supertype BacktranslatedACSLValue replaces BacktranslatedExpression in the public interface of ACSL backtranslation.
  • Make BacktranslatedExpression a record.
  • CACSL2BoogieBacktranslator: refactor extraction and backtranslation of pointer structs. Handle pointer names (now represented by a (private) record PointerVariable) and pointer values separately.

…nslation

- Add a common supertype BacktranslatedACSLValue for BacktranslatedExpression
  and a new FakePointer record (which replaces FakePointerExpression).
  BacktranslatedACSLValue replaces BacktranslatedExpression in the public
  interface of ACSL backtranslation.
- Make BacktranslatedExpression a record.
- CACSL2BoogieBacktranslator: refactor extraction and backtranslation of
  pointer structs. Handle pointer names (now represented by a record
  PointerVariable) and pointer values separately.
@maul-esel maul-esel requested a review from schuessf February 11, 2025 22:34
@maul-esel
Copy link
Contributor Author

Copy link
Contributor

@schuessf schuessf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change 👍

@maul-esel maul-esel merged commit 6ef02ff into dev Feb 12, 2025
3 of 4 checks passed
@maul-esel maul-esel deleted the wip/dk/no-fake-acsl branch February 12, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants