Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format.yml #111

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Update format.yml #111

merged 1 commit into from
Dec 7, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 7, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved GitHub Actions trigger to enhance PR management for the main branch. πŸš€

πŸ“Š Key Changes

  • Updated GitHub Actions workflow to replace pull_request_target with pull_request.
    • Now listens for opened, closed, synchronize, and review_requested events on the main branch.

🎯 Purpose & Impact

  • πŸ›‘οΈ Security: Increases safety by avoiding potential risks associated with pull_request_target, which could expose secrets in workflows from external PRs.
  • πŸ”„ Seamless PR Handling: Ensures better alignment with standard PR workflows, making contribution and review processes smoother for both developers and maintainers.
  • 🌱 Foundation for Growth: Lays groundwork for more secure and scalable automation in this repository.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Dec 7, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/JSON2YOLO πŸš€ pull request! To ensure a seamless integration of your updates, please review the following checklist:

  • βœ… Define a Purpose: Ensure the purpose of your PR is clearly stated in the description. Explain your fix or feature, and link any relevant issues if applicable.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/JSON2YOLO main branch. If it’s out-of-date, resolve conflicts by clicking the 'Update branch' button or running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify that all required Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please investigate and resolve the issues.
  • βœ… Update Documentation: If your PR introduces new functionality or modifies existing features, ensure the relevant documentation is updated.
  • βœ… Add Tests: If this PR involves code changes, please incorporate or update corresponding tests to cover your modifications, ensuring all tests pass successfully.
  • βœ… Sign the CLA: Confirm you’ve signed our Contributor License Agreement (CLA) if this is your first contribution. To do so, comment with "I have read the CLA Document and I sign the CLA."
  • βœ… Minimize Changes: Strive to keep changes limited to what’s necessary for your proposed modification or feature. "Simplicity is the ultimate sophistication." β€” Leonardo da Vinci

For additional guidance, please consult our Contributing Guide. If you have not already, double-check that your PR description adheres to our standards and provides a clear summary of your changes.

This is an automated response to help streamline the contribution process, but rest assured, an Ultralytics engineer will review and assist you with your PR shortly. Thank you for your effort in improving JSON2YOLOβ€”your contribution is greatly valued! πŸŽ‰

@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/JSON2YOLO πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/JSON2YOLO main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. An Ultralytics engineer will also assist with your PR soon. Thank you for contributing to Ultralytics! πŸš€

@glenn-jocher glenn-jocher merged commit 662d9ba into main Dec 7, 2024
4 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch December 7, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants