Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Manifest checksum #306

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Nov 8, 2024

What type of PR is this?

What does this do?

  • New Features

    • Introduced command-line flags --manifest and --base64 for enhanced hash computation options.
    • Added functions for fetching and verifying attestation reports.
  • Improvements

    • Restructured JSON configuration for better organization and naming consistency.
  • Bug Fixes

    • Improved error handling for hash computation and attestation functions.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina changed the title Manifest checksum NOISSUE - Manifest checksum Nov 8, 2024
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.09%. Comparing base (a3577da) to head (727b5e2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/checksum.go 76.19% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   61.97%   62.09%   +0.12%     
==========================================
  Files          54       54              
  Lines        4263     4303      +40     
==========================================
+ Hits         2642     2672      +30     
- Misses       1342     1349       +7     
- Partials      279      282       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit 1e285e3 into ultravioletrs:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants