Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to pass a slice to the preload function #60

Merged
merged 4 commits into from
May 28, 2019
Merged

feat: allow to pass a slice to the preload function #60

merged 4 commits into from
May 28, 2019

Commits on May 28, 2019

  1. feat: allow to pass a slice to the preload function 

    I believe it's more idiomatic for a function to take a slice as a
parameter (vs. a pointer to a slice) to indicate that this function only
mutates the values in the underlying array, and not the length or the
capacity.

For example, that's the case for the sort functions in the standard
library.
    @yansal
    yansal committed May 28, 2019
    Configuration menu
    Copy the full SHA
    d0a0f21 View commit details
    Browse the repository at this point in the history

  2. add tests

    @yansal
    yansal committed May 28, 2019
    Configuration menu
    Copy the full SHA
    98aa230 View commit details
    Browse the repository at this point in the history

  3. add tests

    @yansal
    yansal committed May 28, 2019
    Configuration menu
    Copy the full SHA
    c593bbb View commit details
    Browse the repository at this point in the history

  4. feat: add rules to allow preloading a slice

    @yansal
    yansal committed May 28, 2019
    Configuration menu
    Copy the full SHA
    6b71954 View commit details
    Browse the repository at this point in the history