Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First naive version of datalayer grouping #1351

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yohanboniface
Copy link
Member

image

A few questions/remarks:

  • we are using datalist so groups name have to be written only once and will then appear in autocomplete, but if one wants to reword a group name, they will need to reword it once, but then go to all datalayers of this group to select the new value
  • the "toggle all" button does not reflect the current state of the visibility of the group (tricky: all visible, all hidden, or mixed)
  • at this stage, datalayers without a group are not displayed any more in the browser, letting users choose either to have a group "Others" or let them hidden, but maybe we want something more automatic
  • we do not reflect groups yet in the caption panel, but we should do if this is the direction we want to take
  • going this way, we touch the idea of also changing colors and settings for a whole group at once, so that would mean a sort of datalayer hierarchy, but this would open a lot of questions (perms being maybe the tricky one)
  • no integration tests yet as I'm not sure yet it's the way to go

@yohanboniface yohanboniface marked this pull request as draft November 28, 2023 13:30
@rprovilij
Copy link

rprovilij commented Apr 9, 2024

Hoping to keep the conversation going:

  1. Could a "Rename group" feature automatically iterate over all layers linked with that group? When a group name is changed, layer associations are updated.
  2. The toggle all button may not need to reflect the group's three visibility states, only two of them (hidden/unhidden). The icon could remain as it is in the image if one or more layers remain unhidden.
  3. When creating a new map, the initial layer could be placed within an undefined group (as standard) that would be renamed later. Also the layers of existing maps could be placed in this undefined group.
  4. Groups could for now be reflected in the captions panel with headings.
  5. Enabling grouping for organizational purposes only would already be extremely helpful(!) Implementing hierarchical settings could perhaps be examined in the next step?
  6. Eager to hear your thoughts.

Edit: Changed point 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants