-
Couldn't load subscription status.
- Fork 2.8k
Icon picker: Better title for icon colors #20649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the user-facing display of icon color names in the icon picker modal, making them more meaningful and user-friendly.
Key Changes:
- Added a
nameproperty to each color in theumbracoColorsarray with human-readable labels - Updated the icon picker modal to display the new
nameproperty instead of the technicalalias
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/resources/extractUmbColorVariable.function.ts | Added name property to color objects with user-friendly labels (e.g., "Black" for "text" alias, "Light Blue" for "light-blue" alias) |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.element.ts | Updated color swatch label and title to use the new name property with fallback to alias |
src/Umbraco.Web.UI.Client/src/packages/core/resources/extractUmbColorVariable.function.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @bjarnef - I've tested and all works as expected and improves what we had before.
I had a further thought thought (and sorry I didn't consider this first time around).
Perhaps it would be better still if these were localised. What do you think? Seems you could implement that by removing the name again, using the alias to define a label key, and then localise with label=${this.localize.term('colors_' + toCamelCase(color.alias))}. You could then create translation keys for the non-legacy colours.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This improves the titles for icon colors - especially the title for
textcolor, which isn't meaningful although the alias makes sense in code.