Avoid falling into an infinite cycle due to PHI loop#5
Open
timmyyuan wants to merge 1 commit intoumnsec:mainfrom
Open
Avoid falling into an infinite cycle due to PHI loop#5timmyyuan wants to merge 1 commit intoumnsec:mainfrom
timmyyuan wants to merge 1 commit intoumnsec:mainfrom
Conversation
Contributor
|
Thanks for the catch. I will need to test it on more large programs before merging it. |
Contributor
|
The current implementation for handling PHINode has to be improved. It basically tries each incoming value and selects the "right" one. That is why it uses NVisited to temporarily hold the visited nodes. If we simply use Visited, the analysis results will be incorrect. |
Author
|
I see what you're getting at now. This is a backtracking algorithm. Is there an easy fix for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug can be exposed by mem.bc