Skip to content

fix the dirfs comparisons #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Nov 15, 2023

  • fixes the failing tests on main

I had some time to look into this today, and as it turns out, the reason for the failures is that DirFileSystem instances don't compare equal if the arguments differ slightly or they're passed in a different order. To avoid that, we stop trying to use mapper.dirfs which allows us to get full control over the way the dirfs instance is constructed.

@keewis keewis merged commit ab2e347 into umr-lops:main Nov 15, 2023
@keewis keewis deleted the fix-fsspec-comparison branch November 15, 2023 14:28
@agrouaze
Copy link
Member

Thanks @keewis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants