Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anti meridian cases #173

Closed
wants to merge 3 commits into from

Conversation

agrouaze
Copy link
Member

@agrouaze agrouaze commented Jul 10, 2023

address #172
after testing a solution that would go beyond the raise Error in case of antimeridian, it appears that rastering methods (map_raster and _load_rasters_vars) can simply not handle such geolocations (at least without heavy modification of the function).
Trying the rastering methods leads to artifacts:
image
So it is decided that the comments will be clearer in the code and in the Exception() msg.

@agrouaze agrouaze requested a review from yreynaud July 10, 2023 13:24
@agrouaze agrouaze marked this pull request as draft July 10, 2023 13:24
@agrouaze agrouaze self-assigned this Jul 10, 2023
@agrouaze agrouaze added the bug Something isn't working label Jul 10, 2023
@agrouaze agrouaze linked an issue Jul 10, 2023 that may be closed by this pull request
@agrouaze agrouaze marked this pull request as ready for review July 10, 2023 13:37
@agrouaze agrouaze closed this May 27, 2024
@agrouaze agrouaze deleted the fix_anti_meridian_cases branch May 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant