Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete subscription only if the event is a delete event #771

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Sep 3, 2024

What does this PR do?

Delete subscription from db only if the event is a delete event to prevent out of order events from deleting db entires

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review September 3, 2024 05:58
@BlankParticle BlankParticle force-pushed the blank/feat/delete-subscription-on-delete-only branch from 9204249 to 67f0001 Compare September 3, 2024 06:04
@BlankParticle BlankParticle force-pushed the blank/feat/delete-subscription-on-delete-only branch from 67f0001 to a3c7bda Compare September 3, 2024 06:26
@BlankParticle BlankParticle merged commit c194a2c into main Sep 3, 2024
4 checks passed
@BlankParticle BlankParticle deleted the blank/feat/delete-subscription-on-delete-only branch September 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants