Update glusterfs io callback function signature #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with glusterfs 6.0, the IO callback function takes two additional parameters for stats structs. Ideally there'd be a way to detect which API version we're building against, but nothing convenient seems to exist.
|
I'm not aware what the distribution of glusterfs versions across distributions is, but even CentOS7 (which will be end of life in a few months) came with 6.0. |
|
I'm also pretty sure that this has never worked properly if the library version was 6.0 or higher, which might be an indication on how many people use the glusterfs plugin. |
|
Thanks!
Indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with glusterfs 6.0, the IO callback function takes two additional parameters for stats structs.
Ideally there'd be a way to detect which API version we're building against, but nothing convenient seems to exist.