This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
feat(wallet): implement wizard flow for wallet #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @honoka428 I just wanted to acknowledge that the team is aware of this PR and is looking forward to reviewing it but just need to free up some bandwidth first so we can give it a proper look through. Thanks for the contribution though and addressing this issue! |
|
Very old PR, but definitely something we're still interested in refactoring around. If you want to play around with the latest updates in caravan, everything has been moved to our new monorepo: https://github.com/caravan-bitcoin/caravan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES: #146
Description
This change restructures the wallet generation flow to address the concerns mentioned in the issue linked above.
Major changes include:
WalletGeneratoras it's no longer necessary.See video below for a demo:
caravan-wizard-flow.mov
Does this PR introduce a breaking change?
Does this PR fix an open issue?