Add CDP endpoint verification with exponential backoff for managed browsers #1528
+301
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Managed browsers sometimes failed to start due to timing issues where the browser
process was launched but the CDP endpoint wasn't immediately available, causing
connection failures with "CDP endpoint not ready" errors.
Fixes #1445
Solution
_verify_cdp_ready()method in BrowserManager with exponential backoffList of files changed and why
browser_manager.pystart()methodtests/browser/test_cdp_strategy.pyHow Has This Been Tested?
To try to reproduce the issue, you can remove the hardcoded waiting time in browser_manager.py to mimic the browser taking time to open.
test_cdp_strategy.py, all tests passed.Checklist: