feat(tools): enhance map/replay managers and refine tools sidebar ui

[undead2146]

Summary by CodeRabbit

• Bug Fixes

  • Improved token validation during build process with stricter error handling.
  • Enhanced token injection logic to better tolerate formatting variations.

• Chores

  • Optimized CI/CD pipeline to inject credentials earlier in the build sequence.
  • Enhanced release notes with direct download links to release assets.
  • Improved local development setup with automated environment file handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

✅ Deploy Preview for generalshub ready!

Name	Link
🔨 Latest commit	e6f6e61
🔍 Latest deploy log	https://app.netlify.com/projects/generalshub/deploys/6958901ce4c28b0008b5bcaa
😎 Deploy Preview	https://deploy-preview-10--generalshub.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

CI/CD pipeline enhancements including improved error handling for token injection (PowerShell script now exits with error code 1 on missing token, uses regex-based replacements, and validates post-injection), earlier token injection in Windows/Linux build flows, Markdown-linked assets in release notes, and .env file copying for local debugging in the Windows project.

Changes

Cohort / File(s)	Summary
Token Injection Script .github/scripts/inject-token.ps1	Enhanced error handling: missing token now exits with code 1 (was 0). Replaced simple string replacements with regex-based logic to tolerate whitespace around placeholders. Added post-injection validation to ensure token data (0x) exists.
CI Workflow .github/workflows/ci.yml	Moved token injection steps earlier in Windows and Linux build sequences (after build-info extraction). Removed duplicate injection steps that previously occurred after the Build Projects section.
Release Workflow .github/workflows/release.yml	Converted static asset names to Markdown links: Installer and Portable entries now link to their respective GitHub release asset URLs.
Windows Project Configuration GenHub/GenHub.Windows/GenHub.Windows.csproj	Added conditional ItemGroup to copy top-level .env file to output directory for local debugging (only if file exists; PreserveNewest copy option).

Poem

🐰 A token now flows with validated grace,
Regex patterns check each hiding place,
Workflows shift their steps so neat and true,
Links in releases shine bright and new—
Config files dance in harmony's embrace! ✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title mentions enhancing map/replay managers and refining tools sidebar UI, but the actual changes involve token injection scripts, workflow adjustments, release asset formatting, and .env file configuration—none of which relate to map/replay managers or tools sidebar UI.	Update the PR title to accurately reflect the actual changes, such as 'feat: improve token injection and adjust CI/CD workflows' or similar to match the actual changeset.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7168061 and e6f6e61.

📒 Files selected for processing (4)

• .github/scripts/inject-token.ps1
• .github/workflows/ci.yml
• .github/workflows/release.yml
• GenHub/GenHub.Windows/GenHub.Windows.csproj

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build Windows
• GitHub Check: Build Linux

🔇 Additional comments (7)

GenHub/GenHub.Windows/GenHub.Windows.csproj (1)

32-38: LGTM! Local debugging support properly implemented.

The conditional ItemGroup correctly copies the .env file from the repository root to the output directory only when it exists, using PreserveNewest to avoid unnecessary updates. This provides convenient local debugging support without affecting production builds.

.github/workflows/release.yml (1)

224-225: LGTM! Enhanced user experience with clickable asset links.

The Markdown-formatted links improve the release notes by making assets directly clickable, using proper GitHub context variables for dynamic URL generation.

.github/scripts/inject-token.ps1 (3)

6-7: LGTM! Proper error handling for missing token.

Correctly exits with code 1 when the token is missing, ensuring the CI/CD pipeline fails fast rather than continuing with invalid credentials.

---

30-33: LGTM! More robust placeholder replacement.

The regex-based replacement correctly handles whitespace variations in the placeholder patterns, making the injection more resilient to code formatting changes.

---

35-38: LGTM! Reasonable validation check.

The post-injection validation ensures that hex byte arrays were successfully injected. While the check is simple (looking for "0x"), it's appropriate for catching obvious injection failures.

.github/workflows/ci.yml (2)

126-129: LGTM! Token injection properly placed before build.

The Inject Secrets step is correctly positioned after build info extraction and before the build step, ensuring the token is available when needed.

---

288-291: LGTM! Token injection properly placed before build.

The Inject Secrets step is correctly positioned after build info extraction and before the build step, ensuring the token is available when needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/ci.yml (1)

306-309: Remove duplicate Inject Secrets step.

This Inject Secrets step duplicates the earlier injection at lines 288-291. The earlier injection (before Build Projects) is correctly placed and sufficient. Remove this duplicate to avoid redundant script execution and workflow inefficiency.

🔎 Proposed fix

Remove lines 306-309 entirely, as the token is already injected earlier at lines 288-291:

-      - name: Inject Secrets
-        shell: pwsh
-        run: |
-          ./.github/scripts/inject-token.ps1 -Token "${{ secrets.UPLOADTHING_TOKEN }}"
-

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7168061 and e6f6e61.

📒 Files selected for processing (4)

• .github/scripts/inject-token.ps1
• .github/workflows/ci.yml
• .github/workflows/release.yml
• GenHub/GenHub.Windows/GenHub.Windows.csproj

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build Windows
• GitHub Check: Build Linux

🔇 Additional comments (7)

GenHub/GenHub.Windows/GenHub.Windows.csproj (1)

32-38: LGTM! Local debugging support properly implemented.

The conditional ItemGroup correctly copies the .env file from the repository root to the output directory only when it exists, using PreserveNewest to avoid unnecessary updates. This provides convenient local debugging support without affecting production builds.

.github/workflows/release.yml (1)

224-225: LGTM! Enhanced user experience with clickable asset links.

The Markdown-formatted links improve the release notes by making assets directly clickable, using proper GitHub context variables for dynamic URL generation.

.github/scripts/inject-token.ps1 (3)

6-7: LGTM! Proper error handling for missing token.

Correctly exits with code 1 when the token is missing, ensuring the CI/CD pipeline fails fast rather than continuing with invalid credentials.

---

30-33: LGTM! More robust placeholder replacement.

The regex-based replacement correctly handles whitespace variations in the placeholder patterns, making the injection more resilient to code formatting changes.

---

35-38: LGTM! Reasonable validation check.

The post-injection validation ensures that hex byte arrays were successfully injected. While the check is simple (looking for "0x"), it's appropriate for catching obvious injection failures.

.github/workflows/ci.yml (2)

126-129: LGTM! Token injection properly placed before build.

The Inject Secrets step is correctly positioned after build info extraction and before the build step, ensuring the token is available when needed.

---

288-291: LGTM! Token injection properly placed before build.

The Inject Secrets step is correctly positioned after build info extraction and before the build step, ensuring the token is available when needed.