Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2519] At ProxyHandler append the non-decoded query string to the request #1698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2519] At ProxyHandler append the non-decoded query string to the request #1698

wants to merge 1 commit into from

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Oct 23, 2024

@fl4via fl4via changed the title [UNDERTOW-2519] Attempt fix [UNDERTOW-2519] At ProxyHandler append the non-decoded query string to the request Oct 24, 2024
@fl4via fl4via force-pushed the UNDERTOW-2519 branch 3 times, most recently from 8e8d908 to 58f3eb5 Compare October 24, 2024 15:11
@fl4via fl4via marked this pull request as ready for review October 24, 2024 15:12
@fl4via fl4via added the bug fix Contains bug fix(es) label Oct 24, 2024
@fl4via
[UNDERTOW-2519] At ProxyHandler append the non-decoded query string t…
da8c370 
…o the request, making the query consistent with the rest of the URI of the request, that is appended in the non-decoded form.

For that, we are adding the get/setNonDecodedQueryString methods to HttpServerExchange. HttpRequestParser sets the non-decoded query string only when it is decoded.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
jasondlee
jasondlee approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jasondlee jasondlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ropalka ropalka added the next release This PR will be merged before next release or has already been merged (for payload double check) label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@jasondlee jasondlee jasondlee approved these changes

Assignees
No one assigned
Labels
bug fix Contains bug fix(es) next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl4via @jasondlee @ropalka