Feature/acp regions #342
Open
Feature/acp regions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacug
reviewed
Oct 30, 2019
Comment on lines
7
to
8
| csv = CSV.read(BIOPAMA_COUNTRIES_CSV) | ||
| csv.shift # remove headers |
There was a problem hiding this comment.
I think these two lines can be removed now you are using the foreach at line 10
There was a problem hiding this comment.
Ah, I forgot about those. Fixed now. Thanks, @lucacug !
|
Happy now!! |
|
@stacytalbot We were waiting for JRC to approve this before merging and going on production, but I think they never came back to us (or at least to me). Might be worth double checking internally with the rest of the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to amend the representation of biopama countries and replace the
is_biopamabool with anacp_regionstring to also represent the ACP region countries belong to.This means that countries with
acp_regionequal tonilare not ACP countries.This PR specifically is about updating the CSV source and the importer.
Changes made on the db can be found on the related pp-db PR.
Notes
Wdpa::BiopamaCountriesImporter.importcountriestable. Another potential approach would have been doing a Single Table Inheritance with the region model so that, in the future, we could add different regions for different mappings. However, that requires important changes within the code which would need to be properly scheduled in.