-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/docker network #777
base: develop
Are you sure you want to change the base?
Fix/docker network #777
Conversation
…CK in env and also added API_PATH
chore: update docker instructions for ssh-agent settings for mac users
updated docker compose file to accommodate for mac environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and all works on my machine. good job!
Can you update the credentials in lastpass with the new ones required by these changes when this PR is merged please?
@sergiomarrocoli waiting for feedback from Romoke |
Fix/dockercmd-jenkins: ensure yarn install works by assigning some value to SSH_AUTH_SOCK in env and also added API_PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change the port setting, otherwise it doesn't work on Jenkins.
@@ -25,7 +29,10 @@ services: | |||
db: | |||
container_name: protectedplanet-db | |||
image: kartoza/postgis:11.5-2.5 | |||
network_mode: host | |||
ports: | |||
- "5432:5432" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "5432" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
@@ -34,7 +41,10 @@ services: | |||
redis: | |||
container_name: protectedplanet-redis | |||
image: redis | |||
network_mode: host | |||
ports: | |||
- "6379:6379" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "6379" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
@@ -65,18 +76,24 @@ services: | |||
memlock: | |||
soft: -1 | |||
hard: -1 | |||
network_mode: host | |||
ports: | |||
- "9200:9200" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "9200" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
env_file: | ||
- '.env' | ||
network_mode: host | ||
ports: | ||
- "5601:5601" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "5601" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
@@ -88,19 +105,26 @@ services: | |||
- .:/ProtectedPlanet | |||
- protectedplanet_node_modules:/ProtectedPlanet/node_modules | |||
- protectedplanet_bundler:/usr/local/bundle | |||
network_mode: host | |||
ports: | |||
- "3035:3035" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "3035" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
# - /run/host-services/ssh-auth.sock:/ssh-agent # Use this setting for Mac OS X and comment out ${SSH_AUTH_SOCK}:/ssh-agent below | ||
- ${SSH_AUTH_SOCK}:/ssh-agent | ||
ports: | ||
- "9292:9292" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "9292" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
# - /run/host-services/ssh-auth.sock:/ssh-agent # Use this setting for Mac OS X and comment out ${SSH_AUTH_SOCK}:/ssh-agent below | ||
- ${SSH_AUTH_SOCK}:/ssh-agent | ||
ports: | ||
- "3000:3000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "3000" (without host port), so it won't conflict with host port. This is Jenkins test, no one will connect from the host.
No description provided.