collapse all error lists when opening error

unepwcmc · Sep 7, 2016 · ba2fcd2 · ba2fcd2
1 parent c52f848
commit ba2fcd2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/app/assets/javascripts/trade/controllers/annual_report_upload_controller.js.coffee b/app/assets/javascripts/trade/controllers/annual_report_upload_controller.js.coffee
@@ -40,6 +40,7 @@ Trade.AnnualReportUploadController = Ember.ObjectController.extend Trade.Flash,
 
     transitionToSandboxShipments: (error) ->
       @set('currentError', error)
+      @notifyPropertyChange('allErrorsCollapsed')
       params = {
         validation_error_id: error.get('id')
         page: 1

diff --git a/app/assets/javascripts/trade/templates/annual_report_upload.handlebars b/app/assets/javascripts/trade/templates/annual_report_upload.handlebars
@@ -24,14 +24,14 @@
     errorType="active"
     content=validationErrors
     collapsed=false
-    controller=this}}
+  }}
 
   {{view Trade.ValidationErrorsView
     heading="Ignored validation errors"
     errorType="ignored"
     content=ignoredValidationErrors
     collapsed=true
-    controller=this}}
+  }}
 </div>
 
 {{ outlet }}
diff --git a/app/assets/javascripts/trade/views/annual_report_upload/validation_errors_view.js.coffee b/app/assets/javascripts/trade/views/annual_report_upload/validation_errors_view.js.coffee
@@ -17,6 +17,8 @@ Trade.ValidationErrorsView = Ember.View.extend
     # reset default collapse setting
     if @get('controller.allErrorsCollapsed') == null
       @set('collapsed', @get('defaultCollapsed'))
+    else
+      @set('collapsed', true)
   ).observes('controller.allErrorsCollapsed')
 
   toggleHint: ( ->