feat: Add support for unlimited fieldset tabs items #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarn-e
force-pushed
the
feat/unlimited-fieldset-tab-items
branch
from
c335c85 to
19bdd3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for unlimited fieldset tab items
Motivation
As the library already added unlimited tab items support for inlines, it would make sense to have the same functionality with fieldset tabs
Changes
prefixparameter totabNavigationto reuse the same function, and passing thefieldset-prefix for fieldset tabstabNavigationfunction where the dropdown menu would be rendered outside of the content due to the caluclation not taking the unhidden property into account.fieldsets_tabs.htmlto match that of thetab_items.htmlHow to test
You can check out the PR that showcases the unlimited fieldset tab items: Yarn-e#1
Example screenshots
Before:
After:
Fixes #1687