Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded to Next v12, React v18, and Scripture-Tsv v1.2.0 #645

Merged
merged 2 commits into from
May 8, 2024
Merged

Upgraded to Next v12, React v18, and Scripture-Tsv v1.2.0 #645

merged 2 commits into from
May 8, 2024

Conversation

kintsoogi
Copy link
Contributor

@kintsoogi kintsoogi commented May 2, 2024 •
edited
Loading

Describe what your pull request addresses

  • Upgrade Next to v12
  • Upgrade React to v18
  • Upgrade scripture-tsv to 1.2.0

Test Instructions

  • Open Deploy Preview
  • Verify that Gateway Edit acts as normal
    • Make sure that add/delete TSV item is functional
    • Make sure bible reference functionality is normal
    • Make sure translation helps components are normal (most gEdit functionality)

PhotoNomad0
PhotoNomad0 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kintsoogi kintsoogi force-pushed the kintsoogi-nextUpgrade branch 3 times, most recently from c6bf6d7 to bdfefef Compare May 8, 2024 19:37
@kintsoogi kintsoogi merged commit f1b7b6f into develop May 8, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the kintsoogi-nextUpgrade branch May 8, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhotoNomad0 PhotoNomad0 PhotoNomad0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kintsoogi @PhotoNomad0