CLDR-19098 Refactor ExemplarInfo.java and CheckExemplars.java #5185
+40
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-These changes are automated refactoring by IntelliJ, from accepting suggestions linked to compiler warnings -This is preliminary work related to a plan to move CheckExemplars.ExemplarType to ExemplarInfo.ExemplarType; however it is doubtful whether this org.unicode.cldr.draft.ExemplarInfo was intended rather than a new org.unicode.cldr.util.ExemplarInfo
Member
Author
|
Question: what's the significance of "draft" in package names, like "org.unicode.cldr.draft.ExemplarInfo"? |
Member
|
There isn't any. One thing we might consider is a more meaning ful director structure. But only if not too painful to refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Change public to private wherever possible
-The remaining changes are automated refactoring by IntelliJ, from accepting suggestions linked to compiler warnings
-This is preliminary work related to a plan to move CheckExemplars.ExemplarType to ExemplarInfo.ExemplarType; however it is doubtful whether this org.unicode.cldr.draft.ExemplarInfo was intended rather than a new org.unicode.cldr.util.ExemplarInfo
CLDR-19098
ALLOW_MANY_COMMITS=true