-
Notifications
You must be signed in to change notification settings - Fork 412
CLDR-19109 LDML keyboards for egy, pgd, sa, xct #5186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
mcdurdin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look pretty good to me.
It would be good to remove all commented out code lines that appear in various places, esp. as some of them seem to be halfway between Keyman and LDML format.
The egy-Egyp keyboard will need documentation to be accessible to users, lots of hidden behaviors there, but I don't think we have any way of associating documentation with a keyboard in CLDR.
We could make more use of transform mapping replacements to reduce transform rule count in most of the keyboards. Pros and cons on maintainability.
I see that our variable sets are going to generate very long lines of xml in places, and I think we could change some of them to usets, which may serve to highlight gaps in the range. (This stops us from using mapping, according to the spec, for those sets but we aren't using mapping anyway, just simple capture group insertion.)
|
You need to use a conformant commit message style. You can fix this locally or use the squash option at : |
8e77ed7 to
094c3b9
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
I used squash bot, that unfortunately, that makes the file changes harder to see. Hoping the files are now ready. |
CLDR-19109
ALLOW_MANY_COMMITS=true