Skip to content

Conversation

@xadxura
Copy link

@xadxura xadxura commented Nov 7, 2025

CLDR-19109

  • Add new keyboard layouts for Egyptian Hieroglyphic, Gandhari, Sanskrit, and Tibetan in the Keyboard3 LDML format.
  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@xadxura xadxura requested a review from a team November 7, 2025 18:45
@srl295
Copy link
Member

srl295 commented Nov 7, 2025

keyboards/3.0/pgd-Khar-t-k0-qwerty.xml: ERROR: contains UTF-8 BOM (shouldn't happen in CLDR XML files)

mcdurdin
mcdurdin previously approved these changes Nov 8, 2025
Copy link
Contributor

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look pretty good to me.

It would be good to remove all commented out code lines that appear in various places, esp. as some of them seem to be halfway between Keyman and LDML format.

The egy-Egyp keyboard will need documentation to be accessible to users, lots of hidden behaviors there, but I don't think we have any way of associating documentation with a keyboard in CLDR.

We could make more use of transform mapping replacements to reduce transform rule count in most of the keyboards. Pros and cons on maintainability.

I see that our variable sets are going to generate very long lines of xml in places, and I think we could change some of them to usets, which may serve to highlight gaps in the range. (This stops us from using mapping, according to the spec, for those sets but we aren't using mapping anyway, just simple capture group insertion.)

@srl295
Copy link
Member

srl295 commented Nov 8, 2025

You need to use a conformant commit message style. You can fix this locally or use the squash option at :

https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/5186

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@xadxura
Copy link
Author

xadxura commented Nov 9, 2025

You need to use a conformant commit message style. You can fix this locally or use the squash option at :

https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/5186

I used squash bot, that unfortunately, that makes the file changes harder to see. Hoping the files are now ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants