-
Notifications
You must be signed in to change notification settings - Fork 414
CLDR-18871 Create new locale, Interslavic, isv #5204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1c789de to
b42896d
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
I think the colon after the ticket number (at the beginning of the commit message) is causing problems. I think it may be too early to include "isv" in en.xml. @srl295: Correct me if I'm wrong! IIUC the locale needs to have been in CLDR at Basic level already in order to qualify for addition to en.xml, which would then be done at the beginning of the next even-numbered cycle. Thus, assuming isv gets to Basic in v50, at the beginning of v52 "isv" would be added to en.xml and picked up by other locals for localization. |
|
Other files look okay, though I'm not qualified to comment about GenerateLikelySubtags.java. (@srl295 ?) |
CLDR-18871: Fix exemplars
b42896d to
cbd3e76
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
oh! I suspect you are right
I don't think its ever too early to include it. Adding it here means it can be localized but it doesn't require it. It's only required to be translated if we update coverageLevels.xml. I think it's a better practice to add it immediately when we add the locale. |
srl295
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but i thought English changes should be separate
| <language type="inh">Ingush</language> | ||
| <language type="io">Ido</language> | ||
| <language type="is">Icelandic</language> | ||
| <language type="isv">Interslavic</language> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <language type="isv">Interslavic</language> |
i thought it was not usual policy to include the English change here - should be a separate ticket?
CLDR-18871
ALLOW_MANY_COMMITS=true