Add ICU4X 1.5 #239
Open
Add ICU4X 1.5 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be done in a way that reduces duplication especially in main.rs? |
|
with a lot of work sure. is it worth it? |
|
Thanks for working on this, Rob! Question to Shane & Elango: any reason not to approve this? A new main.rs may be necessary. |
sffc
reviewed
Jul 1, 2024
Comment on lines
+107
to
+125
| // TODO!!! : supported_test_map to call the functions. | ||
| let json_result = if test_type == "collation_short" { | ||
| run_collation_test(&json_info) | ||
| } else if (test_type == "decimal_fmt") || (test_type == "number_fmt") { | ||
| run_numberformat_test(&json_info) | ||
| } else if (test_type == "display_names") | ||
| || (test_type == "language_display_name") | ||
| || (test_type == "lang_names") | ||
| { | ||
| run_language_name_test(&json_info) | ||
| } else if test_type == "likely_subtags" { | ||
| run_likelysubtags_test(&json_info) | ||
| } else if test_type == "list_fmt" { | ||
| run_list_fmt_test(&json_info) | ||
| } else if test_type == "plural_rules" { | ||
| run_plural_rules_test(&json_info) | ||
| } else { | ||
| Err(test_type.to_string()) | ||
| }; |
There was a problem hiding this comment.
This kind of code is highly likely to go stale. It would be nice to keep it in sync across versions. I don't immediately see why it needs to be different between 1.4 and 1.5?
Beyondyou92
approved these changes
Sep 2, 2024
| @@ -11,7 +11,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| icu4x-version: [ '1.3', '1.4' ] | |||
|
Hey Rob, can we resolve these issues to add version 1.5? How can I help? |
|
Maybe @sffc can update this to his satisfaction. |
|
It's a bit unfortunate that this has bitrot since I left my review in June/July |
|
It's very unfortunate that this was not merged in June. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.