Reduce debug noise for issue #336 #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Jan 8, 2025
schema/check_generated_data.py
Outdated
| @@ -15,20 +15,20 @@ | |||
| import schema_validator | |||
| from schema_files import ALL_TEST_TYPES | |||
|
|
|||
| logger = logging.Logger("Checking Test Data vs. Schemas LOGGER") | |||
| logger.setLevel(logging.INFO) | |||
There was a problem hiding this comment.
Suggestion: often these libraries have a way to set the logging level from an environment variable or from the CLI, so that you can do something like DEBUG=* ./genData or ./genData -vv
There was a problem hiding this comment.
Yes, that's possible. I'll take a look.
Also, I've removed lots of excessive logging in the latest commits.
One more thing: when executing in parallel, the individual threads cannot have a logger in their objects because a logger "cannot be pickled". That's a small complication / limit to logging.
There was a problem hiding this comment.
I think don't pickle the logger; just make a new one for each thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes excessive debug output from conformance test logs.