Skip to content

Use consistent naming for {Composing,Decomposing}Normalizer FFI #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linusg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use consistent naming for {Composing,Decomposing}Normalizer FFI #7183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ffi/capi/bindings/c/DecomposingNormalizer.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ffi/capi/bindings/cpp/icu4x/DecomposingNormalizer.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ffi/capi/src/normalizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ pub mod ffi {
)]
#[diplomat::attr(not(supports = utf8_strings), disable)]
#[diplomat::attr(*, rename = "is_normalized")]
pub fn is_normalized(&self, s: &DiplomatStr) -> bool {
pub fn is_normalized_utf8(&self, s: &DiplomatStr) -> bool {
self.0.as_borrowed().is_normalized_utf8(s)
}

Expand Down Expand Up @@ -314,7 +314,7 @@ pub mod ffi {
)]
#[diplomat::attr(not(supports = utf8_strings), disable)]
#[diplomat::attr(*, rename = "is_normalized_up_to")]
pub fn is_normalized_up_to(&self, s: &DiplomatStr) -> usize {
pub fn is_normalized_utf8_up_to(&self, s: &DiplomatStr) -> usize {
self.0.as_borrowed().split_normalized_utf8(s).0.len()
}

Expand Down
Loading