Merged
Conversation
nedley
force-pushed
the
ned/emoji_17_alpha
branch
from
d95dd91 to
288e56b
Compare
nedley
commented
Jan 8, 2025
| gender(Emoji.FEMALE), | ||
| role(Emoji.WOMAN_STR), | ||
| family(Emoji.NEUTRAL_FAMILY), | ||
| family(Emoji.NEUTRAL_FAMILY, "group"), |
Contributor
Author
There was a problem hiding this comment.
This is a minor fix to chart tooltips, which currently call any multi-person group a family.
Contributor
Author
|
Issue 1 is because a generated sequence looks like "1F468 1F3FF 200D 1F430 200D 1F468 1F3FF" but that should have been normalized to "1F46F 1F3FF". |
nedley
force-pushed
the
ned/emoji_17_alpha
branch
from
288e56b to
0056070
Compare
Contributor
Author
|
Force-pushed a fix for the first three issues I noted. |
nedley
force-pushed
the
ned/emoji_17_alpha
branch
2 times, most recently
from
46e2d9c to
7f8cf2c
Compare
nedley
commented
Jan 9, 2025
| ImmutableMap.<String, String>builder() | ||
| .put("🧑🏿❤️💋🧑🏿", "💏🏿") | ||
| .put("🧑🏿❤️🧑🏿", "💑🏿") | ||
| .put("👨🏿🐰👨🏿", "👯🏿") |
Contributor
Author
There was a problem hiding this comment.
I’m still not entirely sure what distinguishes these from (say) handshakes, but it works for now.
nedley
force-pushed
the
ned/emoji_17_alpha
branch
from
7f8cf2c to
991808f
Compare
Contributor
Author
|
One more force-push to fix ordering. Any additional changes for the remaining issues will be handled in a new PR. |
eggrobin
approved these changes
Jan 9, 2025
macchiati
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new emoji as draft candidates and rebuild data files. Known issues:
proposalData.txt has not been updated yet, there is an issue with the naming of the new group sequences that I haven’t tracked down yet.internal/emoji-proposals.txt thinks new group sequences are missing proposals, likely another manifestation of the previous issue.MAP_TO_COUPLESis using MAN rather than ADULT, maybe this is the same issue yet again?Ordering is not final but should be nailed down by the upcoming UTC.