Add example with latest version of Node#206
Conversation
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Looks good. Update the commit messages; use other commit messages in the commit history as example of the commit structure to use. Make commits tell what they do, not how they do it. It shouldn't say "YAML files" (how) it should say "workflow files" (what).
RobertaWaa
force-pushed
the
http-node25
branch
from
e8159af to
0421113
Compare
There was a problem hiding this comment.
Use a single commit message.
Use the prefix: feat(node) to the commit message.
Turn this into a full PR.
Use your proper name in the commit authorship and signed-off-by. Use Roberta Necula <anarobiqq@gmail.com> instead of RobertaWaa <anarobiqq@gmail.com>.
RobertaWaa
force-pushed
the
http-node25
branch
from
0421113 to
24f4413
Compare
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Use the same name for authorship and for signed off by. Currently you use Ana-Naria Roberta NECULA (is Naria correct) and RobertWaa).
Improve your commit message: it's too long, it's inconsistent, it starts with a small letter. Suggestion: feat(examples,worflows): Add Node 25
Add Node 25 example together with workflow files. Signed-off-by: Ana-Maria Roberta NECULA <anarobiqq@gmail.com>
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
2 participants
No description provided.