Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Add GSoC'24 UEFI GOP, Part III Post #450

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

procub3r
Copy link
Contributor

@procub3r procub3r commented Aug 7, 2024

No description provided.

@procub3r procub3r force-pushed the gsoc-blog branch 5 times, most recently from b207da2 to 80a34e8 Compare August 7, 2024 16:46
@procub3r
Copy link
Contributor Author

procub3r commented Aug 7, 2024

Fixed all linter issues.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@procub3r please use your full name for the signoff, commiter and author fields.

Author: procub3r <procub3r@proton.me>
Commit: procub3r <procub3r@proton.me>

    blog: Add GSoC'24 UEFI GOP, Part III Post
    
    Signed-off-by: procub3r <procub3r@proton.me>

Use git config --global user.name and then amend the commit.

content/blog/2024-08-07-gsoc-uefi-gop.mdx Outdated Show resolved Hide resolved
@StefanJum
Copy link
Member

Also @mogasergiu please take a quick look.

@StefanJum StefanJum requested a review from mogasergiu August 8, 2024 17:44
Copy link
Member

@mogasergiu mogasergiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Sergiu Moga sergiu@unikraft.io

@StefanJum
Copy link
Member

@procub3r the author name and email is still wrong

Author: procub3r <procub3r@proton.me>
Commit: Sriprad Potukuchi <sripradp@proton.me>

    blog: Add GSoC'24 UEFI GOP, Part III Post
    
    Signed-off-by: Sriprad Potukuchi <sripradp@proton.me>

Signed-off-by: Sriprad Potukuchi <sripradp@proton.me>
@procub3r
Copy link
Contributor Author

@StefanJum Fixed now. Didn't know I had to change that separately 😅

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

@StefanJum StefanJum merged commit 5faf4e6 into unikraft:main Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants