fix(initrd): Reverse order of detection #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaSeri
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Hi @craciunoiuc, thanks for this!
Please see my comment, which is related to the fixes in #1696 and #1698.
Lowercase paths currently resolve to docker links. By reversing order we can exclude local files by checking for them. Links will usually be valid. Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/correctly-detect-rootfs
branch
from
9c8875a to
6f84313
Compare
craciunoiuc
changed the title
LucaSeri
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
All good, thanks!
Reviewed-by: Luca Seritan luca.seritan@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes