Skip to content

fix(cloud): Correct typo showing incorrect error message #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(cloud): Correct typo showing incorrect error message #1744

merged 1 commit into from
Jul 1, 2024

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc
fix(cloud): Correct typo showing incorrect error message
86b1d7c 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc craciunoiuc added this to the KraftKit v0.9.0 milestone Jun 26, 2024
@craciunoiuc craciunoiuc requested a review from nderjung June 26, 2024 15:39
nderjung
nderjung reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the gomod update, that'll be achieved with the compose rework

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/fixes-volumes branch from 070afdc to 86b1d7c Compare July 1, 2024 09:34
@craciunoiuc craciunoiuc requested a review from nderjung July 1, 2024 09:35
@nderjung nderjung changed the title fix(cloud): Additional volume attach fixes fix(cloud): Correct typo showing incorrect error message Jul 1, 2024
nderjung
nderjung approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nderjung nderjung merged commit fb06b2d into unikraft:staging Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nderjung nderjung nderjung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
KraftKit v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@craciunoiuc @nderjung