Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build error with mimalloc.h, where size_t definition is not included #10

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

JadenMajid
Copy link

@JadenMajid JadenMajid commented Sep 24, 2023

Build error: size_t is defined in stddef.h but stddef.h was not included
Change: included stddef.h to the mimalloc.h file to resolve lack of definition

Build error, size_t is defined in stddef.h but stddef.h was not included

Signed-off-by: Jaden Majid <majid.jaden@gmail.com>
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JadenMajid, please update the commit message to something more desriptive (e.g. Add the stddef.hheader tomimalloc.h`)

@JadenMajid JadenMajid changed the title Update mimalloc.h Add the stddef.h header to mimalloc.h Sep 24, 2023
@JadenMajid
Copy link
Author

@StefanJum Updated the commit message

@JadenMajid JadenMajid changed the title Add the stddef.h header to mimalloc.h Fixing build error with mimalloc.h, where size_t definition is not included Sep 24, 2023
@StefanJum
Copy link
Member

@JadenMajid You need to update the commit message using git commit --amend and then do a git push --force, just updating the PR description will not work.

@JadenMajid
Copy link
Author

@StefanJum I did as you advised, can you confirm if it worked?

@StefanJum
Copy link
Member

@JadenMajid the commit still did not update, you can check it under the commits page https://github.com/unikraft/lib-mimalloc/pull/10/commits

@razvand
Copy link

razvand commented Sep 24, 2023

@JadenMajid , please see the comment from @StefanJum .

@razvand razvand added the enhancement New feature or request label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants